-
Notifications
You must be signed in to change notification settings - Fork 0
v0.6.0 #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
v0.6.0 #34
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
1681238
Initial plan
Copilot 5f11a57
Change node aesthetics from color to fill
Copilot 2017b4e
Use fillable shape codes (21-25) for nodes to work with fill aesthetic
Copilot c717ab5
Fix test failures: update for fill aesthetic and numeric shapes
Copilot 0f53aee
Improve code coverage: add fill aesthetic tests and nocov markers
Copilot ea3da1f
Replace Rgraphviz with igraph::layout_with_sugiyama for Sugiyama layouts
Copilot 8bc7164
Improve test name clarity for hierarchy layout test
Copilot ef2b3dd
Improve Sugiyama layout with dummy nodes and barycenter crossing mini…
Copilot 9766630
Add clarifying comment for 0-based layer indexing
Copilot ac90d2e
Separated isolates where they complicate graphing
jhollway a68b5c1
Added legend option for annotating isolates
jhollway 05ee30b
Added caption option for annotating isolates
jhollway eb3d70f
Changed legend labelling for Sign and Mode
jhollway 20fc867
Closed #12 by using fill shapes
jhollway fd1e40c
Updated a number of outdated tests
jhollway 203ff30
graphr testing now cycles through all data objects, excluding multi-o…
jhollway f6ddbf6
Moved isolate inference to helper
jhollway 2817ad1
Consolidated all legend modifications to graph_legends()
jhollway 3d17ee9
If graphr() passed a list of graphs, it will instead use graphs()
jhollway 00db4f0
graphs() no longer requires patchwork, because this is now a regular …
jhollway 89d1b33
#minor bump
jhollway c6e28f5
Updated logo
jhollway f868ebd
Initial plan
Copilot 13aa438
Update NEWS.md for v0.6.0 with all PR changes
Copilot dc4b477
Updated news and tests
jhollway 1407362
Fixed check errors
jhollway eb60ac5
Removed scales from the package as unnecessary with current theming
jhollway 84cc664
Improved snap performance for lattices
jhollway d3b9571
Dropped scale_*() functions for each institution as redundant
jhollway 908ac75
Closed #18 by correcting rotation for lattice snapping, still unique …
jhollway 8192f84
No more palette gen
jhollway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
|
|
||
| graph_legends <- function(p, g, | ||
| node_color = NULL, node_shape = NULL, node_size = NULL, | ||
| edge_color = NULL, edge_size = NULL) { | ||
| p + | ||
| ggplot2::guides(fill = ggplot2::guide_legend(order = 1, | ||
| title = ifelse(is.null(node_color), | ||
| "Color", node_color)), | ||
| color = ggplot2::guide_legend(order = 2), | ||
| shape = ggplot2::guide_legend(order = 3, | ||
| title = ifelse(is.null(node_shape), | ||
| ifelse(manynet::is_twomode(g), "Mode", "Shape"), | ||
| node_shape)), | ||
| size = ggplot2::guide_legend(order = 4, | ||
| title = ifelse(is.null(node_size), | ||
| "Size", node_size)), | ||
| linetype = ggplot2::guide_legend(order = 5), | ||
| edge_colour = ggplot2::guide_legend(order = 6, | ||
| title = ifelse(is.null(edge_color), | ||
| ifelse(manynet::is_signed(g), "Sign", "Color"), | ||
| edge_color)), | ||
| edge_size = ggplot2::guide_legend(order = 7, | ||
| title = ifelse(is.null(edge_size), | ||
| ifelse(manynet::is_weighted(g), "Weight", "Size"), | ||
| edge_size)), | ||
| alpha = ggplot2::guide_legend(order = 99, | ||
| override.aes = list( alpha = 0, size = 0, shape = NA ))) | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.