Conversation
…alues with impute
…utside of the range of `startTime` and `endTime`
…der for clarity and conciseness.
* Rename class diagnostics functions. * WIP rename make data functions.
…e, now at 58%. Also implemented and tested different history options for trans.
…n to the same changes Merge branch 'feature/history' of https://github.com/stocnet/goldfish into feature/history # Conflicts: # R/functions_effects_DyNAM_choice.R
…s to the REM functions calling the updated choice functions
Merge branch 'feature/history' into refactor/rename-functions # Conflicts: # R/functions_parsing.R
- ignoreRep to ignore_repetitions - transformFun to transformer_fn - aggregateFun to summarize_fn - isTwoMode to is_two_mode
…and preprocessing
Merge branch 'refactor/rename-functions' into develop # Conflicts: # NEWS.md
Merge branch 'main' into develop # Conflicts: # vignettes/dynami-example.R # vignettes/dynami-example.Rmd # vignettes/teaching/plot-teaching2-1.png # vignettes/teaching1.R # vignettes/teaching2.R # vignettes/teaching2.Rmd
Collaborator
|
This is great @auzaheta . Let's maybe catch up today when you get in? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This Pull Request introduces a significant set of enhancements and refactoring to the
goldfishpackage, aiming to improve consistency, clarity, and extend the functionality of various effects. These changes are part of our continuous effort to align with modern R package development best practices and thestocnetecosystem.Here's a detailed summary of the key changes:
New
historyArgument fortrans()andcycle()Effects:historyargument to thetrans()(transitivity) andcycle()effects. This argument allows users to specify how the temporal sequence or consecutiveness of events influences the calculation of these effects (e.g.,"pooled","sequential","consecutive"). This provides greater flexibility for modelling nuanced dynamic network processes.New
make_data()Function for Data Preparation:make_data()function has been introduced to align with Stocnet style. This centralises data preprocessing logic and adapts the existing estimation functions (estimate_*) to utilise this new interface. This improves data flow.Tidyverse-Style Renaming of Functions and Arguments:
snake_caseconvention. This enhances readability, consistency, and aligns the package with the widely adopted tidyverse style guide, making it more intuitive for R users.Dedicated Options Management for Estimation and Preprocessing:
set_estimate_opt()andset_preprocessing_opt()functions. These provide a clear and centralised way for users to set and review internal algorithms' arguments related to the estimation and preprocessing phases, respectively. This improves transparency and user control over the model fitting pipeline.Explicit Naming for Estimation Functions:
modelargument from the mainestimate()function has been removed. Instead, users now call specific functions directly to estimate different model types:estimate_dynam(),estimate_dynami(), andestimate_rem(). This makes the user interface more explicit and discoverable.Closes Issue #105
Closes Issue #100
These changes collectively represent a significant step forward in the usability, maintainability, and extensibility of the
goldfishpackage.Checklist: