Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Release bump to migraph 1.6.6, focused on packaging/release metadata updates plus small test/print-method hygiene and tutorial formatting tweaks.
Changes:
- Bump package version to 1.6.6 and update dependency constraints (notably
autograph). - Remove
{netrics}tutorial tests; tighten some testthat expectations (expect_length()). - Make several S3
print()methods return the printed object invisibly; minor tutorial/Rmd formatting cleanups.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/testthat/test-tutorials_netrics.R |
Removes {netrics} tutorial testing. |
tests/testthat/test-model_tests.R |
Switches length() assertions to expect_length(). |
R/model_tests.R |
print.network_test() now returns x invisibly. |
R/class_models.R |
print.netlm() / print.netlogit() now return x invisibly. |
R/class_makes.R |
print.diffs_model() / print.over_memb() now return invisibly (with a behavior caveat noted in comments). |
NEWS.md |
Adds 1.6.6 release notes. |
inst/tutorials/tutorial9/ergm.Rmd |
Minor learnr and ggplot numeric formatting tweaks. |
inst/tutorials/tutorial8/diversity.Rmd |
Minor learnr argument formatting tweak. |
inst/tutorials/tutorial0/tutorial0.Rmd |
Line wrapping/formatting in examples/comments. |
DESCRIPTION |
Version bump to 1.6.6; dependency constraint updates. |
cran-comments.md |
Adds CRAN dependency-check notes (but needs alignment with actual dependency versions). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
23
to
+27
| print.diffs_model <- function(x, ...){ | ||
| x <- x[,colSums(x, na.rm=TRUE) != 0] | ||
| x$I_new <- NULL | ||
| print(dplyr::tibble(x, ...)) | ||
| invisible(x) |
|
|
||
| ## Package | ||
|
|
||
| - Improved goodpractices |
Comment on lines
12
to
+17
| - Updated manynet dependency to 1.2.1 to fix reverse dependency issue | ||
| - Updated netrics dependency to 0.3.1 to fix reverse dependency issue | ||
| - Checked with CRAN versions of dependencies | ||
| - Only issue was CRAN versions of manynet and netrics built under R v4.6.1, | ||
| whereas this package was built locally under R v4.6.0, | ||
| though this should not be a problem for CRAN submission. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist: