Skip to content

v1.6.6#318

Merged
jhollway merged 2 commits into
mainfrom
develop
Jun 23, 2026
Merged

v1.6.6#318
jhollway merged 2 commits into
mainfrom
develop

Conversation

@jhollway

Copy link
Copy Markdown
Collaborator

Description

Checklist:

  • Documentation
    • DESCRIPTION file version is bumped by the appropriate increment (major, minor, patch)
    • Longer functions are commented inline or broken down into helper functions to help debugging
  • PR form
    • Title indicates expected version number
    • PR description above and the NEWS.md file are aligned
    • Description above itemizes changes under subsection titles, e.g. "## Data""
    • Closed, fixed, or related issues are referenced and explained in the description above, e.g. "Fixed #0 by adding A"

Copilot AI review requested due to automatic review settings June 23, 2026 11:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Release bump to migraph 1.6.6, focused on packaging/release metadata updates plus small test/print-method hygiene and tutorial formatting tweaks.

Changes:

  • Bump package version to 1.6.6 and update dependency constraints (notably autograph).
  • Remove {netrics} tutorial tests; tighten some testthat expectations (expect_length()).
  • Make several S3 print() methods return the printed object invisibly; minor tutorial/Rmd formatting cleanups.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
tests/testthat/test-tutorials_netrics.R Removes {netrics} tutorial testing.
tests/testthat/test-model_tests.R Switches length() assertions to expect_length().
R/model_tests.R print.network_test() now returns x invisibly.
R/class_models.R print.netlm() / print.netlogit() now return x invisibly.
R/class_makes.R print.diffs_model() / print.over_memb() now return invisibly (with a behavior caveat noted in comments).
NEWS.md Adds 1.6.6 release notes.
inst/tutorials/tutorial9/ergm.Rmd Minor learnr and ggplot numeric formatting tweaks.
inst/tutorials/tutorial8/diversity.Rmd Minor learnr argument formatting tweak.
inst/tutorials/tutorial0/tutorial0.Rmd Line wrapping/formatting in examples/comments.
DESCRIPTION Version bump to 1.6.6; dependency constraint updates.
cran-comments.md Adds CRAN dependency-check notes (but needs alignment with actual dependency versions).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread R/class_makes.R
Comment on lines 23 to +27
print.diffs_model <- function(x, ...){
x <- x[,colSums(x, na.rm=TRUE) != 0]
x$I_new <- NULL
print(dplyr::tibble(x, ...))
invisible(x)
Comment thread NEWS.md

## Package

- Improved goodpractices
Comment thread cran-comments.md
Comment on lines 12 to +17
- Updated manynet dependency to 1.2.1 to fix reverse dependency issue
- Updated netrics dependency to 0.3.1 to fix reverse dependency issue
- Checked with CRAN versions of dependencies
- Only issue was CRAN versions of manynet and netrics built under R v4.6.1,
whereas this package was built locally under R v4.6.0,
though this should not be a problem for CRAN submission.
@jhollway jhollway merged commit 6b8528e into main Jun 23, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants