Skip to content

Update Node.js version #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndelangen merged 9 commits into from
Nov 13, 2025
Merged

Update Node.js version #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
248603b
Update Node.js version in .nvmrc to 22.16.0 and rename setup step in …
ndelangen Nov 13, 2025
0b7d39f
Add auto.config.cjs for configuration management with base branch and…
ndelangen Nov 13, 2025
a7f4cc2
Update tsup configuration to target Node.js 22 and streamline entry d…
ndelangen Nov 13, 2025
9ddc6ed
Remove rimraf dependency from package.json and update TypeScript lib …
ndelangen Nov 13, 2025
a08f50d
Update release workflow to use 'pnpm run release' for consistency in …
ndelangen Nov 13, 2025
18eb6ae
Update tsconfig.json to change rootDir to the project root and includ…
ndelangen Nov 13, 2025
38e4aa9
Downgrade 'auto' dependency version from 11.3.0 to 11.1.1 in package.…
ndelangen Nov 13, 2025
d96dc0f
Refactor tsconfig.json to update module target to es2015, remove allo…
ndelangen Nov 13, 2025
f3dd7e7
Upgrade 'auto' dependency from version 11.1.1 to 11.3.0 in package.js…
ndelangen Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
with:
fetch-depth: 0

- name: Use Node.js 22.x
- name: Setup Node
uses: actions/setup-node@v3

- uses: pnpm/action-setup@v4
Expand All @@ -20,12 +20,10 @@ jobs:
run: pnpm install

- name: Build
run: |
pnpm build
run: pnpm build

- name: Release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: |
pnpm release
run: pnpm run release
3 changes: 2 additions & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
22.12
22.16.0

2 changes: 1 addition & 1 deletion auto.config.js → auto.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
export default {
module.exports = {
baseBranch: 'main',
labels: [
{
Expand Down
1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
"auto": "^11.3.0",
"picocolors": "^1.1.0",
"prettier": "^3.5.3",
"rimraf": "^6.0.1",
"storybook": "^10.0.0",
"tsup": "^8.5.0",
"typescript": "^5.9.3",
Expand Down
66 changes: 2 additions & 64 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,16 @@
"esModuleInterop": true,
"skipLibCheck": true,
"target": "esnext",
"allowJs": true,
"resolveJsonModule": true,
"moduleDetection": "force",
"moduleResolution": "bundler",
"module": "preserve",
"module": "es2015",
Copy link
Copy Markdown
Member

@Sidnioulz Sidnioulz Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen I'm wondering if es2015 is actually supported or not. I think we could've kept preserve here, that's what we have in the addon-kit.

Copy link
Copy Markdown
Member Author

@ndelangen ndelangen Nov 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't used by esbuild anyway AFAIK

"jsx": "react",
"isolatedModules": true,
"verbatimModuleSyntax": true,
"strict": true,
"noUncheckedIndexedAccess": true,
"noImplicitOverride": true,
"noImplicitAny": true,
"lib": ["es2023", "dom", "dom.iterable"],
"baseUrl": ".",
"rootDir": "./src"
"lib": ["esnext", "dom", "dom.iterable"],
"rootDir": "."
},
"include": ["src/**/*"]
"include": ["src/**/*", "tsup.config.ts"]
}
8 changes: 4 additions & 4 deletions tsup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { defineConfig } from 'tsup';

export default defineConfig((options) => [
export default defineConfig(() => [
{
entry: ['src/index.ts', 'src/preset.ts'],
outDir: './dist',
splitting: true,
format: ['esm'],
dts: true,
dts: true,
treeshake: true,
sourcemap: false,
/*
Expand All @@ -22,10 +22,10 @@ dts: true,
{
entry: ['src/postinstall.ts'],
outDir: './bin',
splitting: true,
splitting: true,
format: ['esm'],
treeshake: true,
target: 'node20',
target: 'node22',
clean: false,
platform: 'node',
esbuildOptions(options) {
Expand Down