Upload Splat: Send media token to scene and persist via save manager#1199
Open
tanish2k09 wants to merge 1 commit intomainfrom
Open
Upload Splat: Send media token to scene and persist via save manager#1199tanish2k09 wants to merge 1 commit intomainfrom
tanish2k09 wants to merge 1 commit intomainfrom
Conversation
Collaborator
tanish2k09
commented
Mar 24, 2026
tanish2k09
commented
- Propagate assetToken through upload3DObjects progressCallback so callers receive it on success
- UploadModalSplat.onSuccess now delivers the media token instead of raw bytes
- Controls3D uses addObject() with AssetType.SPLAT to add the splat through the proper queue/undo path
- Remove unused onLocalBytes prop and dead commented-out code
- Fix ObjectJSON missing top-level media_file_type field so type is correctly restored on scene reload (previously always undefined, breaking outliner icons for all object types)
- Propagate assetToken through upload3DObjects progressCallback so callers receive it on success - UploadModalSplat.onSuccess now delivers the media token instead of raw bytes - Controls3D uses addObject() with AssetType.SPLAT to add the splat through the proper queue/undo path - Remove unused onLocalBytes prop and dead commented-out code - Fix ObjectJSON missing top-level media_file_type field so type is correctly restored on scene reload (previously always undefined, breaking outliner icons for all object types)
✅ Deploy Preview for artcraft-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for storyteller-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for genhub-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
|
Fixes #1177 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.