3D: Fix editor undo/redo keybinds and hotkey signal bugs#1252
Open
tanish2k09 wants to merge 1 commit intomainfrom
Open
3D: Fix editor undo/redo keybinds and hotkey signal bugs#1252tanish2k09 wants to merge 1 commit intomainfrom
tanish2k09 wants to merge 1 commit intomainfrom
Conversation
Collaborator
tanish2k09
commented
Mar 30, 2026
tanish2k09
commented
- Ctrl+Z/Cmd+Z was calling redo() instead of undo(); fixed and added missing Ctrl+Shift+Z/Cmd+Shift+Z and Ctrl+Y redo bindings
- Wrap all async keybind handlers in try/finally so isProcessing is always cleared even if undo/redo/copy/paste throws
- Fix === typo in disableHotkeyInput (comparison instead of assignment), and use full value replacement so the Preact signal update is reactive
- Ctrl+Z/Cmd+Z was calling redo() instead of undo(); fixed and added missing Ctrl+Shift+Z/Cmd+Shift+Z and Ctrl+Y redo bindings - Wrap all async keybind handlers in try/finally so isProcessing is always cleared even if undo/redo/copy/paste throws - Fix === typo in disableHotkeyInput (comparison instead of assignment), and use full value replacement so the Preact signal update is reactive
✅ Deploy Preview for genhub-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for artcraft-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for storyteller-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.