fix(json-crdt): guard ObjNode.children against missing nodes#1047
Open
privateJiangyaokai wants to merge 1 commit into
Open
fix(json-crdt): guard ObjNode.children against missing nodes#1047privateJiangyaokai wants to merge 1 commit into
privateJiangyaokai wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ObjNode.children()passes the result ofindex.get(id)straight to the callback with a non-null assertion:index.get(id)can legitimately returnundefinedwhen a key references a node id that is not present in the model index (e.g. a dangling reference encountered while applying a patch). The!assertion hides this, soundefinedreaches the callback.The most visible symptom is a crash in
Model._gcTree(formerlydeleteNodeTree), which readsvalue.sidon its argument before theindex.getexistence check:When an
ObjNodehas a child key pointing at a missing node,children()invokes the callback withundefined, and_gcTree(undefined)throwsCannot read properties of undefined (reading 'sid'), aborting the whole patch/GC pass.Fix
Guard against the missing node before invoking the callback — exactly what
ArrNode.children()andVecNode.children()already do:This makes
ObjNodeconsistent with the other collection nodes:ArrNode.children:const node = index.get(data[i]); if (node) callback(node);VecNode.children:const node = index.get(id); if (node) callback(node);Only
ObjNodewas missing the guard (and additionally used an unsound!). No behavior change for well-formed models; it only prevents a hard crash when a dangling reference is present.