Conversation
|
@tuteng:Thanks for your contribution. For this PR, do we need to update docs? |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f2a0f7e30
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR updates the Helm charts to source the toolset’s BusyBox and Kubectl initContainer images from new top-level images.busybox / images.kubectl values, while attempting to keep backward compatibility with the previous images.toolset.* locations.
Changes:
- Add top-level
images.busyboxandimages.kubectldefaults (and markimages.toolset.busybox/images.toolset.kubectlas deprecated). - Update toolset templates to use new helper functions for resolving BusyBox/Kubectl image fields.
- Add
_helpers.tplfunctions to resolve BusyBox/Kubectl image repository/tag/pullPolicy with fallback behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| charts/sn-platform/values.yaml | Adds new top-level BusyBox/Kubectl image values and deprecation notes. |
| charts/sn-platform/templates/toolset/toolset-statefulset.yaml | Switches BusyBox initContainer image fields to helper-based resolution. |
| charts/sn-platform/templates/toolset/jwt-secret-init-job.yaml | Switches Kubectl initContainer image fields to helper-based resolution. |
| charts/sn-platform/templates/_helpers.tpl | Adds helper functions to resolve BusyBox/Kubectl images with fallback. |
| charts/sn-platform-slim/values.yaml | Same values changes as sn-platform for the slim chart. |
| charts/sn-platform-slim/templates/toolset/toolset-statefulset.yaml | Same BusyBox template change as sn-platform-slim plus minor whitespace tweak. |
| charts/sn-platform-slim/templates/toolset/jwt-secret-init-job.yaml | Same Kubectl template change as sn-platform-slim. |
| charts/sn-platform-slim/templates/_helpers.tpl | Same helper additions as sn-platform-slim. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
(If this PR fixes a github issue, please add
Fixes #<xyz>.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>to link to the master issue.)Master Issue: #
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)