Fix: parsing ATTRIBUTE-DEFINITION-REAL default values#210
Merged
stanislaw merged 2 commits intoApr 9, 2026
Merged
Conversation
…AL attribute default values
simonas-drauksas-sensmetry
force-pushed
the
fix/real-default-as-integer
branch
from
April 9, 2026 11:38
6c49614 to
68b5bec
Compare
Contributor
|
Hey @simonas-drauksas-sensmetry, thanks for contributing! Let me resolve the mypy issue later this evening as it is not related to your patch. I will merge your change after it. |
An attempt to fix CI failures
Contributor
Author
Ah, I had just ran the |
Contributor
|
I will check another issue later today (#209), and should be able to release a new Pip right away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing an
ATTRIBUTE-DEFINITION-REALattribute that had aDEFAULT-VALUE, the parser was looking for anATTRIBUTE-VALUE-INTEGERchild element instead ofATTRIBUTE-VALUE-REAL. This caused an assertion failure whenever a real-typed attribute definition included a default value.This fix corrects the tag name. A unit test covering this case is also added.