fix(spec_object_parser): handle SPEC-OBJECT with no <VALUES> element#213
Merged
stanislaw merged 1 commit intoMay 5, 2026
Merged
Conversation
ReqIF-1.2 §10.8.40 makes <VALUES> optional. The parser previously asserted that attributes is not None after parsing, which raised AssertionError on any SPEC-OBJECT without a <VALUES> child. Replace the assert with an `or []` fallback and tighten the return type from Optional[List[...]] to List[...]. Add test_03_missing_values_element to cover this case.
Contributor
|
Thanks! |
Contributor
|
@fNBU would you like a release right away/soon, or you are preparing more patches like this? |
Contributor
Author
|
There will probably be more. Me and my colleagues don't need a release in order to use the changes, so it's up to you. |
Contributor
Nice, thanks for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ReqIF-1.2 §10.8.40 makes optional. The parser previously asserted that attributes is not None after parsing, which raised AssertionError on any SPEC-OBJECT without a child.
Replace the assert with an
or []fallback and tighten the return type from Optional[List[...]] to List[...].Add test_03_missing_values_element to cover this case.