feat: add support for unresolved expressions#1063
Draft
malinjawi wants to merge 1 commit intosubstrait-io:mainfrom
Draft
feat: add support for unresolved expressions#1063malinjawi wants to merge 1 commit intosubstrait-io:mainfrom
malinjawi wants to merge 1 commit intosubstrait-io:mainfrom
Conversation
|
Mohammad Linjawi seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #515
This adds minimal protocol support for partially bound / unresolved expressions in Substrait.
Changes included:
Type.Unknownas a placeholder type for partially bound expressionsExpression.NamedExpressionfor unresolved name-based referencesExpressionandExtendedExpressionunknownThis keeps the design minimal:
unknownand/orNamedExpressionValidation:
buf lintbuf generatepytestcoverage for the new examples and parser/type handlingThis PR adds representational support only. Consumers still need to bind unresolved names, types, and function references before execution unless they define unresolved-expression semantics themselves.
Note: the large generated diffs are from regenerating the checked-in ANTLR parser artifacts after adding
unknownto the grammar.This change is