Fix/600 improve process item deletion error handling#632
Open
neilcroft wants to merge 2 commits intosuitenumerique:mainfrom
Open
Fix/600 improve process item deletion error handling#632neilcroft wants to merge 2 commits intosuitenumerique:mainfrom
neilcroft wants to merge 2 commits intosuitenumerique:mainfrom
Conversation
If the object storage is unreachable or returns an error, the item should still be deleted from the database. Closes suitenumerique#600
Use process_item_deletion to delete stale pending items so that eventual files on the storage are also removed. Refs suitenumerique#600
neilcroft
force-pushed
the
fix/600-improve-process-item-deletion-error-handling
branch
from
becc1c1 to
c74b116
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The task
process_item_deletioncrashes if the object storage is unreachable,leaving orphan items in the database. Also, the
clean_pending_itemscommanddeletes items from DB without cleaning their files from storage.
Closes #600
Proposal
ClientErrorandBotoCoreErrorarounddefault_storage.delete()inprocess_item_deletionso the item is still removed from DB on storage failuresoft_delete()→hard_delete()→process_item_deletion.delay()inclean_pending_itemsto also remove orphan files from storage