Skip to content

enhance: tolerate removed segments during L1 commit #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunby merged 1 commit into from
Sep 3, 2026
Merged

enhance: tolerate removed segments during L1 commit #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/streamingnode/server/wal/vchannel/segment/lifecycle_writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ package segment

import (
"context"
"errors"
"strconv"

"github.com/milvus-io/milvus/internal/types"
"github.com/milvus-io/milvus/pkg/v3/mlog"
"github.com/milvus-io/milvus/pkg/v3/proto/datapb"
"github.com/milvus-io/milvus/pkg/v3/proto/streamingpb"
"github.com/milvus-io/milvus/pkg/v3/proto/viewpb"
Expand Down Expand Up @@ -44,6 +46,17 @@ func (w *segmentLifecycleWriter) CommitL1Segment(ctx context.Context, meta *stre
err := retry.Do(ctx, func() error {
resp, err := w.coord.SaveBinlogPaths(ctx, req)
if err := merr.CheckRPCCall(resp, err); err != nil {
if errors.Is(err, merr.ErrSegmentNotFound) {
// The segment no longer exists in DataCoord (dropped or removed):
// there is nothing to commit, so ignore the error and treat the
// commit as done. DataCoord itself ignores writes to dropped
// segments (returns success), and retrying or failing the segment
// here would only surface a lifecycle event as a task failure.
mlog.Warn(ctx, "segment no longer exists in DataCoord, ignore the L1 commit",
mlog.Int64("segmentID", meta.GetSegmentId()),
mlog.String("vchannel", meta.GetVchannel()))
return nil
}
return err
}
version = dataVersionFromStatus(resp.GetExtraInfo())
Expand Down
Loading