enhance: update storage for S3 retry logging - #24
Merged
sunby merged 1 commit intoSep 9, 2026
Merged
Conversation
Pin milvus-storage to f4e9dafb91eb2280f11cd411992ab1016e70be10 from the sijie-ni-0214 fork. This revision adds ConnectRetryStrategy warning logs with the S3 exception, HTTP status, attempted retry count, retry decision, and error message. Signed-off-by: sijie-ni-0214 <sijie.ni@zilliz.com>
sunby
merged commit Sep 9, 2026
e87f64a
into
sunby:codex/load-1m-segments-pr-stack-rebased-qv-work
6 of 8 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin milvus-storage to f4e9daf from the sijie-ni-0214 fork. This revision adds concise
S3 retry:warning logs inConnectRetryStrategywith the exception name, HTTP status, attempted retry count, retry decision, and error message, including the final decision when the retry budget is exhausted.Validation:
git diff --checkpassed.