fix: avoid empty streaming query shards - #34
Open
sunby wants to merge 1 commit into
Open
Conversation
Signed-off-by: sunby <sunbingyi1992@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After an SN restarts before persisting a Ready view as Up, a delayed Up/Dropped push can register an empty shard. Vchannel-only query planning may then return
VIEW_NOT_FOUNDeven though a replacement replica has an Up view.Create missing shards only for batches containing Preparing; otherwise report the lost view without indexing a shard. For unknown replica IDs, try the other vchannel candidates when a candidate has no Up view. Preserve explicit-replica lookup, context errors, query leases, and draining of accepted reports during WAL handoff.
Validation:
-race -tags dynamic,test -gcflags="all=-N -l" -count=1on the target base; nine related QueryPlan/adaptor/client tests and the dynamic package build also passed.run_clang_format.shwith clang-format 15, andgit diff --checkpassed.make lint-fixwas run but stopped at the existinginternal/metastore/kv/querycoord/kv_catalog_test.go:372: undefined: mockstypecheck error. Unrelated formatter changes were restored. No cluster deployment was performed.Related: #16.
issue: milvus-io#40451