fix(storage): percent-encode object key in cdn purge urls - #384
Merged
Tr00d merged 1 commit intoAug 25, 2026
Merged
Conversation
Tr00d
approved these changes
Aug 25, 2026
Contributor
|
Well done, thanks @fresh55 for your contributions 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #298
a ? or # in an object key was read as the start of a query string or fragment, so the purge hit the wrong path:
this percent-encodes each path segment, same as supabase/supabase-js#2545.
upstream only did this for the two purge urls, not for sign/render/object, so i kept it to the same two.
i didn't put the encoding in
GetFinalPathbecause the upload methods return that value back to the caller as the key.