Skip to content

feat: add nanobot client support (corrected config key)#51

Merged
Dhravya merged 2 commits intomainfrom
vorflux/add-nanobot-support
Apr 14, 2026
Merged

feat: add nanobot client support (corrected config key)#51
Dhravya merged 2 commits intomainfrom
vorflux/add-nanobot-support

Conversation

@vorflux
Copy link
Copy Markdown

@vorflux vorflux bot commented Apr 14, 2026

Adds support for nanobot as a supported MCP client.

This is a corrected version of #47 — the original PR used mcp.servers as the config key, but per nanobot's actual documentation, MCP servers are configured under tools.mcpServers in ~/.nanobot/config.json.

Changes:

  • Added nanobot to getClientPaths() with:
    • Global path: ~/.nanobot/config.json
    • Local path: .nanobot/config.json
    • Config key: tools.mcpServers (nested under the tools object, handled by the existing dot-notation getNestedValue/setNestedValue helpers)
  • Added nanobot to the clientNames array
  • Added 3 new unit tests for nanobot: client name inclusion, configKey/path validation, and local path behavior

Reference: nanobot MCP configuration docs

Testing

  • Build: npm run build passes successfully
  • Unit tests: bun test — all 7 tests pass (4 existing + 3 new nanobot tests)
    • should include nanobot in supported clients — verifies nanobot is in clientNames
    • should return correct path and configKey for nanobot client — verifies configKey is tools.mcpServers and path contains .nanobot/config.json
    • should return local path for nanobot when local flag is true — verifies local path resolution

Note: The CI "Claude Code Review" workflow failure is unrelated to this change — it rejects PRs created by bots unless they're in the allowed_bots list.


Session Details

Vorflux AI added 2 commits April 14, 2026 17:02
Add nanobot (https://github.com/HKUDS/nanobot) as a supported client.

- Config path: ~/.nanobot/config.json
- Local path: .nanobot/config.json
- Config key: tools.mcpServers (MCP servers live under the 'tools' object)

Fixes the configKey from the original PR #47 which used 'mcp.servers' -
the correct key per nanobot's documentation is 'tools.mcpServers'.
@Dhravya Dhravya merged commit beba95c into main Apr 14, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant