Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits. It should be safe to Approve and Run the workflows that need maintainer approval. |
|
Thanks @martin-raden ! I'll let the lesson maintainers decide from here :) |
|
Thanks @martin-raden — I’m happy to merge this. Keeping the comic light in dark mode makes sense, as it would be difficult to recreate faithfully with a dark palette. For the other images I’m conscious that dark‑mode users aren’t all the same: some are fine with light figures, but others do prefer content that’s explicitly designed for dark backgrounds. These diagrams are simpler and arguably better candidates for explicit dark‑mode color conversions. That said, I'm not a dark mode user and welcome all contributions :-) |
Auto-generated via `{sandpaper}`
Source : d5cb59b
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-04-10 06:22:02 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : f179db0
Branch : main
Author : erinmgraham <erin.graham@jcu.edu.au>
Time : 2026-04-10 06:20:03 +0000
Message : Merge pull request #1114 from martin-raden/patch-dark-mode
keep comic light mode
Auto-generated via `{sandpaper}`
Source : f179db0
Branch : main
Author : erinmgraham <erin.graham@jcu.edu.au>
Time : 2026-04-10 06:20:03 +0000
Message : Merge pull request swcarpentry#1114 from martin-raden/patch-dark-mode
keep comic light mode
Auto-generated via `{sandpaper}`
Source : 4437c3e
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-04-10 06:58:51 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : f179db0
Branch : main
Author : erinmgraham <erin.graham@jcu.edu.au>
Time : 2026-04-10 06:20:03 +0000
Message : Merge pull request swcarpentry#1114 from martin-raden/patch-dark-mode
keep comic light mode
Auto-generated via `{sandpaper}`
Source : d5cb59b
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-04-10 06:22:02 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : f179db0
Branch : main
Author : erinmgraham <erin.graham@jcu.edu.au>
Time : 2026-04-10 06:20:03 +0000
Message : Merge pull request #1114 from martin-raden/patch-dark-mode
keep comic light mode
Auto-generated via `{sandpaper}`
Source : 4437c3e
Branch : md-outputs
Author : GitHub Actions <actions@github.com>
Time : 2026-04-10 06:58:51 +0000
Message : markdown source builds
Auto-generated via `{sandpaper}`
Source : f179db0
Branch : main
Author : erinmgraham <erin.graham@jcu.edu.au>
Time : 2026-04-10 06:20:03 +0000
Message : Merge pull request swcarpentry#1114 from martin-raden/patch-dark-mode
keep comic light mode
Hi @froggleston
thanks for the comments in PR #1113
given that, find attached the duplication of the comic to keep it light in dark mode.
personally, I prefer also the merge, conflict, .. SVGs suited for keeping them light, but since the thread you linked leaves them dark, I left them out for now.
If the maintainers are interested, I can add
-darkduplicates for these files too.Best,
Martin