Skip to content

keep comic light mode#1114

Merged
erinmgraham merged 1 commit intoswcarpentry:mainfrom
martin-raden:patch-dark-mode
Apr 10, 2026
Merged

keep comic light mode#1114
erinmgraham merged 1 commit intoswcarpentry:mainfrom
martin-raden:patch-dark-mode

Conversation

@martin-raden
Copy link
Copy Markdown
Contributor

Hi @froggleston

thanks for the comments in PR #1113

given that, find attached the duplication of the comic to keep it light in dark mode.

personally, I prefer also the merge, conflict, .. SVGs suited for keeping them light, but since the thread you linked leaves them dark, I left them out for now.

If the maintainers are interested, I can add -dark duplicates for these files too.

Best,
Martin

@github-actions
Copy link
Copy Markdown

🆗 Pre-flight checks passed 😃

This pull request has been checked and contains no modified workflow files, spoofing, or invalid commits.

It should be safe to Approve and Run the workflows that need maintainer approval.

@froggleston
Copy link
Copy Markdown
Contributor

Thanks @martin-raden ! I'll let the lesson maintainers decide from here :)

@erinmgraham erinmgraham merged commit f179db0 into swcarpentry:main Apr 10, 2026
1 check passed
@erinmgraham
Copy link
Copy Markdown
Contributor

Thanks @martin-raden — I’m happy to merge this. Keeping the comic light in dark mode makes sense, as it would be difficult to recreate faithfully with a dark palette.

For the other images I’m conscious that dark‑mode users aren’t all the same: some are fine with light figures, but others do prefer content that’s explicitly designed for dark backgrounds. These diagrams are simpler and arguably better candidates for explicit dark‑mode color conversions.

That said, I'm not a dark mode user and welcome all contributions :-)

github-actions bot pushed a commit that referenced this pull request Apr 10, 2026
Auto-generated via `{sandpaper}`
Source  : f179db0
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2026-04-10 06:20:03 +0000
Message : Merge pull request #1114 from martin-raden/patch-dark-mode

keep comic light mode
github-actions bot pushed a commit that referenced this pull request Apr 10, 2026
Auto-generated via `{sandpaper}`
Source  : d5cb59b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-04-10 06:22:02 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : f179db0
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2026-04-10 06:20:03 +0000
Message : Merge pull request #1114 from martin-raden/patch-dark-mode

keep comic light mode
github-actions bot pushed a commit to erinmgraham/git-novice that referenced this pull request Apr 10, 2026
Auto-generated via `{sandpaper}`
Source  : f179db0
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2026-04-10 06:20:03 +0000
Message : Merge pull request swcarpentry#1114 from martin-raden/patch-dark-mode

keep comic light mode
github-actions bot pushed a commit to erinmgraham/git-novice that referenced this pull request Apr 10, 2026
Auto-generated via `{sandpaper}`
Source  : 4437c3e
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-04-10 06:58:51 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : f179db0
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2026-04-10 06:20:03 +0000
Message : Merge pull request swcarpentry#1114 from martin-raden/patch-dark-mode

keep comic light mode
github-actions bot pushed a commit that referenced this pull request Apr 14, 2026
Auto-generated via `{sandpaper}`
Source  : d5cb59b
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-04-10 06:22:02 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : f179db0
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2026-04-10 06:20:03 +0000
Message : Merge pull request #1114 from martin-raden/patch-dark-mode

keep comic light mode
github-actions bot pushed a commit to erinmgraham/git-novice that referenced this pull request Apr 14, 2026
Auto-generated via `{sandpaper}`
Source  : 4437c3e
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2026-04-10 06:58:51 +0000
Message : markdown source builds

Auto-generated via `{sandpaper}`
Source  : f179db0
Branch  : main
Author  : erinmgraham <erin.graham@jcu.edu.au>
Time    : 2026-04-10 06:20:03 +0000
Message : Merge pull request swcarpentry#1114 from martin-raden/patch-dark-mode

keep comic light mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants