libc++: prevent the creation of libc++ targets#12613
Open
compnerd wants to merge 1 commit intoswiftlang:stable/21.xfrom
Open
libc++: prevent the creation of libc++ targets#12613compnerd wants to merge 1 commit intoswiftlang:stable/21.xfrom
compnerd wants to merge 1 commit intoswiftlang:stable/21.xfrom
Conversation
When the shared library is disabled, simply avoid creating the target. This is required for environments which CMake does not natively understand and will fallback to a static library for the shared target resulting in multiple generation rules for the same target. Apply the same logic to the static library to maintain similar behaviour.
Member
Author
|
@swift-ci please test LLVM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the shared library is disabled, simply avoid creating the target. This is required for environments which CMake does not natively understand and will fallback to a static library for the shared target resulting in multiple generation rules for the same target. Apply the same logic to the static library to maintain similar behaviour.