[VFS] Guard against null key/value nodes when parsing YAML overlay (#190506)#12722
Merged
mustartt merged 1 commit intostable/21.xfrom Apr 13, 2026
Merged
[VFS] Guard against null key/value nodes when parsing YAML overlay (#190506)#12722mustartt merged 1 commit intostable/21.xfrom
mustartt merged 1 commit intostable/21.xfrom
Conversation
…lvm#190506) When a VFS overlay YAML file contains malformed content such as tabs, the YAML parser can produce KeyValueNode entries where `getKey` returns nullptr. The VFS overlay parser then passes the nullptr to `parseScalarString`, which then calls dyn_cast. Switch to `dyn_cast_if_present` for the above callsites and a few more. (cherry picked from commit 412d694)
Author
|
@swift-ci please test |
jansvoboda11
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a VFS overlay YAML file contains malformed content such as tabs, the YAML parser can produce KeyValueNode entries where
getKeyreturns nullptr. The VFS overlay parser then passes the nullptr toparseScalarString, which then calls dyn_cast.Switch to
dyn_cast_if_presentfor the above callsites and a few more.(cherry picked from commit 412d694)
rdar://171640245