[clang] Report direct module deps for explicitly built modules (#190757)#12740
Open
Bigcheese wants to merge 1 commit intoswiftlang:stable/21.xfrom
Open
[clang] Report direct module deps for explicitly built modules (#190757)#12740Bigcheese wants to merge 1 commit intoswiftlang:stable/21.xfrom
Bigcheese wants to merge 1 commit intoswiftlang:stable/21.xfrom
Conversation
Author
|
@swift-ci please test |
jansvoboda11
approved these changes
Apr 8, 2026
Author
|
@swift-ci please test |
Author
|
@swift-ci please test windows |
…190757) Implicitly built modules do not include PCM paths in .d files because the compiler is the one managing them, but for explicitly built modules the build system needs to know about them so that if one is deleted the build system will rebuild it. Explicitly built modules should only report direct dependencies, as the build system knows about each PCM in the module graph. This adds `-fmodule-file-deps=direct` to support that, and changes dependency scanning to use this in the explicit build commands it outputs. Assisted-by: claude-opus-4.6 (cherry picked from commit 8c389f3)
Bigcheese
force-pushed
the
dev/direct-module-deps-21.x
branch
from
f5fb7a1 to
ef0a3c6
Compare
Author
|
Rebasing to see if that fixes the Windows failure. |
Author
|
@swift-ci please test |
Author
|
@swift-ci please test linux |
Author
|
@swift-ci please test windows |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicitly built modules do not include PCM paths in .d files because the compiler is the one managing them, but for explicitly built modules the build system needs to know about them so that if one is deleted the build system will rebuild it.
Explicitly built modules should only report direct dependencies, as the build system knows about each PCM in the module graph. This adds
-fmodule-file-deps=directto support that, and changes dependency scanning to use this in the explicit build commands it outputs.Assisted-by: claude-opus-4.6
(cherry picked from commit 8c389f3)