[CMake] Don't remove sourcekit-inproc from _SWIFT_DEFAULT_COMPONENTS in SwiftComponents.cmake#88159
Merged
rintaro merged 1 commit intoswiftlang:mainfrom Mar 30, 2026
Merged
Conversation
rintaro
reviewed
Mar 27, 2026
Member
|
@swift-ci Please build toolchain macOS |
Steffeeen
force-pushed
the
sourcekitdinproc-framework
branch
from
773fc1c to
e284812
Compare
SourceKit always needs sourcekit-inproc. With this change we always get a `lib/sourcekitdInProc.framework` directory in the swift build directory. This can then be used in SourceKit-LSP to run SourceKitD in-process on macOS for debugging.
Steffeeen
force-pushed
the
sourcekitdinproc-framework
branch
from
e284812 to
dd51213
Compare
Member
|
@swift-ci Please smoke test |
Member
|
(toolchain build is running in https://ci.swift.org/job/swift-PR-toolchain-macos/2281/) |
Member
|
It turned out that, toolchain builds are not affected by this because they are explicitly specifying the components. In practice, the only case affected are at-desk builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SourceKit always needs sourcekit-inproc. With this change we always get a
lib/sourcekitdInProc.frameworkdirectory in the swift build directory (e.g.,build/Ninja-RelWithDebInfoAssert/swift-macosx-arm64). This can then be used in SourceKit-LSP to run SourceKitD in-process on macOS for debugging. For more context see swiftlang/sourcekit-lsp#2580.