[IRGenDebugInfo][CodeView] Name inner type member in bound generic sized containers#88419
Open
speednoisemovement wants to merge 1 commit intoswiftlang:mainfrom
Open
[IRGenDebugInfo][CodeView] Name inner type member in bound generic sized containers#88419speednoisemovement wants to merge 1 commit intoswiftlang:mainfrom
speednoisemovement wants to merge 1 commit intoswiftlang:mainfrom
Conversation
…zed containers As a workaround for issues with uniquing, bound generics are emitted as a nested structure: - A sized outer structure with no name or identifier - A sizeless inner structure with the mangled name as the name and no identifier. The actual mechanism of connection for the inner and outer structures is that the outer structure has a single unnamed member whose type is the inner structure. However, LLVM CodeView emission treats unnamed members as anonymous structs and tries to inline their members into the parent. But since the inner struct has no members, the effect is that it gets dropped. This change names the inner struct with the mangled type name. This will have the effect of preserving the inner struct in CodeView output, and allow us to use a variation of the DWARF logic at https://github.com/swiftlang/llvm-project/blob/cd1235e59b87c84144802ab85592ee75a615f231/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserSwift.cpp#L166 to recognize and handle this pattern. More details and discussion at swiftlang#87093
Contributor
Author
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a workaround for issues with uniquing, bound generics are emitted as a nested structure:
The actual mechanism of connection for the inner and outer structures is that the outer structure has a single unnamed member whose type is the inner structure.
However, LLVM CodeView emission treats unnamed members as anonymous structs and tries to inline their members into the parent. But since the inner struct has no members, the effect is that it gets dropped.
This change names the inner struct with the mangled type name. This will have the effect of preserving the inner struct in CodeView output, and allow us to use a variation of the DWARF logic at
https://github.com/swiftlang/llvm-project/blob/cd1235e59b87c84144802ab85592ee75a615f231/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserSwift.cpp#L166 to recognize and handle this pattern.
More details and discussion at #87093