Completely disable MouseWheelDirective if not needed - #516
Open
novarx wants to merge 1 commit into
Open
Conversation
This makes it possible to still listen to onMouseWheel Events when no Zoom/Trackpad is enabled.
novarx
marked this pull request as ready for review
July 11, 2023 14:51
Author
|
If you need an working example, let me know. |
novarx
marked this pull request as draft
July 11, 2023 15:19
novarx
marked this pull request as ready for review
July 11, 2023 15:29
Author
|
@marjan-georgiev Any chance to get a review on that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it possible to still listen to onMouseWheel Events when no Zoom/Trackpad is enabled.
What kind of change does this PR introduce?
What is the current behavior?
It's currently not possible to listen to any
mouseWheelEvent, when hovering over the graph area, which i.e. prevents the page from scrolling.his behavior is because of
MouseWheelDirective::mouseWheelFuncresp.event.preventDefault()which is always called, no matter if it is used or not.What is the new behavior?
This Change makes it possible to still listen to onMouseWheel Events, if Zoom and Trackpad is disabled, over the graph.
Does this PR introduce a breaking change?