Skip to content

(release): 10.0.0-alpha.1 - #606

Open
corvo-007 wants to merge 1 commit into
swimlane:masterfrom
corvo-007:node-click-fix
Open

(release): 10.0.0-alpha.1#606
corvo-007 wants to merge 1 commit into
swimlane:masterfrom
corvo-007:node-click-fix

Conversation

@corvo-007

Copy link
Copy Markdown

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)
Currently, When a node is dragged and mouse button is released, It triggers the click event and select event is emitted from the ngx-graph component.

What is the new behavior?
Select event will only be emitted if the node wasn't dragged.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@corvo-007

Copy link
Copy Markdown
Author

Hi @marjan-georgiev , Please review.

@corvo-007

Copy link
Copy Markdown
Author

@steveblue , @marjan-georgiev, Can you merge this fix and create a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant