chore: remove unused @angular/animations dependency - #634
Open
cmgchess wants to merge 1 commit into
Open
Conversation
Author
|
hi @steveblue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
@angular/animationsis listed as an explicit dependency in the rootpackage.jsonand as a peer dependency in the library'spackage.json, but is not used anywhere in the library. It is also deprecated.What is the new behavior?
@angular/animationsis removed from both the rootpackage.jsonand the library'sprojects/swimlane/ngx-graph/package.jsonpeer dependencies, along withyarn.lock.Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
yarn why @angular/animationsconfirms no other package depends on it transitively.package-lock.jsonwas not modified as this project uses yarn as its package manager. It was unclear whether it needed to be updated as well. Open to guidance on this.fix #635