Fixes Ajv 8 breaking changes, adds additional editor enhancements - #1038
Open
crimson-cata1yst wants to merge 4 commits into
Open
Fixes Ajv 8 breaking changes, adds additional editor enhancements#1038crimson-cata1yst wants to merge 4 commits into
crimson-cata1yst wants to merge 4 commits into
Conversation
✅ Deploy Preview for ngx-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Author
|
Could I get a review of this please? This is a critical blocker for my team to finish upgrading to Angular 17+, it would much appreciated :) @steveblue @surya-pabbineedi @marjan-georgiev @Prasanth-Boyina (or someone). Thanks in advance! |
|
I also need this change. Can this be reviewed and merged? Thanks! @surya-pabbineedi @marjan-georgiev @Prasanth-Boyina |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken validation caused from the upgrade to Ajv 8+ in ngx-ui 47.0.0
Adds extra optional inputs on the json editor/flat editor to allow apps to pass in their own options, formats, and keywords to the validator service.
Ajv handles strict schemas in line with JTD now; initialized strict to 'true' on new Ajv instantiations, but it can be overrode with the optional options input.
Resolves JsonEditor Validation Broken in 47.1.0 #1037
Nothing remarkable with the screenshot - just showing that validation works again
Checklist
/projects/swimlane/ngx-ui/CHANGELOG.mdunder HEAD (Unreleased)*required