Skip to content

Remove bref/symfony-bridge#1283

Closed
Nyholm wants to merge 1 commit into
symfony:mainfrom
Nyholm:bref-symfony-bridge
Closed

Remove bref/symfony-bridge#1283
Nyholm wants to merge 1 commit into
symfony:mainfrom
Nyholm:bref-symfony-bridge

Conversation

@Nyholm

@Nyholm Nyholm commented Sep 19, 2021

Copy link
Copy Markdown
Member
Q A
License MIT
Packagist https://packagist.org/packages/bref/symfony-bridge

This recipe is replaced by symfony/recipes#1001

@github-actions

Copy link
Copy Markdown

Thanks for the PR 😍

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@t-richard

Copy link
Copy Markdown
Contributor

@Nyholm I find this confusing, in brefphp/bref#1032 you say

I also didnt want to remove docs how to use Bref with non-runtime symfony applications. That is why I added a new page.

But removing this and moving files to the recipe for runtime/bref makes it harder for people using the FPM layer because they are on older symfony versions or don't want to use the runtime for some reason.

Removing this would force us to rollback changes to the Symfony part of Bref docs to put back Serverless framework examples that were auto-generated by the recipe.

I understand that the Runtime is the way to go now and I would probably use it on my projects but this seems like a step backward to me.

If this is merged, then my take would be to rework bref docs first to use the runtime instead of FPM. If this is not possible, I would instead keep this recipe as-is and add only files related to runtime/bref in its recipe.

In any case, I would like this PR to wait so that we can have a proper discussion in the bref community and adapt bref docs if necessary.

@Nyholm

Nyholm commented Sep 19, 2021

Copy link
Copy Markdown
Member Author

Oh. You are correct. I don’t think about that. Hm. Maybe we should close this PR. Let’s leave it open for a while to see how the discussion goes.

Thank you.

@fabpot

fabpot commented Dec 17, 2022

Copy link
Copy Markdown
Member

Closing for now then.
Feel free to reopen.

@fabpot fabpot closed this Dec 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants