chore(ci): Bump Nix Shell's Node.js from 18 to 20#1306
Merged
Conversation
leviport
approved these changes
Sep 3, 2025
thomas-zimmerman
approved these changes
Sep 3, 2025
thomas-zimmerman
left a comment
Contributor
There was a problem hiding this comment.
Live test still works fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to test #1301, I found that a fresh clone of the repo on a system with a fully updated Nix installation (
nix-channel --update) would no longer work, because Node.js 18 is end-of-life and Nix has removed it from their repo. This updates the package name to use the next LTS release.npm ciandnpm startstill work to build the repo after doing this.This does not affect the live site, only building locally in a Nix shell.