taproot updates: fix htlc scripts correctness#21
Merged
t-bast merged 1 commit intot-bast:masterfrom May 24, 2022
Merged
Conversation
Owner
|
@antonilol there is now a spec proposal for taproot, don't hesitate to post feedback on it: lightning/bolts#995 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script public key order was not consistent with the signatures and preimages need to be 32 bytes
i could also swap the signatures around but chose this order because bolt 03 also does the remote sig first (arbitrary)