improve: 优化构建产物文件名 - #7869
Conversation
# Conflicts: # docs/lib/downloadLinks.test.ts # docs/lib/downloadLinks.ts
t8y2
left a comment
There was a problem hiding this comment.
维护者补丁已推送:b4eb241fd(原 head 82cc27e,先并入 main@7e24f4007 解决冲突 —— merge 提交 b7b83f3,downloadLinks.ts/.test.ts 冲突按「main 的新文案 + PR 的新文件名后缀」保留双方意图;release.yml 自动合并干净)。
补丁要点:
- 关键修正:tauri-action v0 的输入名是
assetNamePattern,PR 原写的releaseAssetNamePattern会被静默忽略(改名不生效但所有消费方已切到新名,必然 404)。已改为正确输入名。 - 作用域收窄:pattern 会让 matrix 腿的每个 bundle 产物都改名,因此只在 aarch64 腿(macOS arm + Linux arm)设置
DBX_[version]_arm64[setup][ext];x64 腿留空保持默认命名(x64.dmg、amd64.deb/rpm/AppImage、_en-US.msi),Linux x64 下载链接与包管理惯例不受影响。Windows 构建的 pattern 整行移除(默认名本就正确,原 pattern 只会误删 msi 的_en-US后缀)。 - 同步遗漏消费方:installer.nsi:549 的 Win7 跳转深链与守护测试更新为新离线包名;scripts/release.mjs 回滚校验改为同时接受
arm64.dmg(新)与aarch64.dmg(旧,回滚目标可能是改名前的版本),release.test.mjs 参数化并新增 2 个用例;顺带修复了 main 上既有的一条失败测试(sccache 注释行误匹配,过滤注释行后恢复)。 - 全仓 grep 复查:
webview2-109/webview2-offline-setup零残留;aarch64.dmg仅剩回滚兼容与历史版本 updater 测试(正确);amd64.AppImage仅 downloadLinks(与作用域一致保留)。
本地验证:node --test scripts/release.test.mjs 11/11、node --test .github/scripts/*.test.mjs 91/91、downloadLinks/windowsInstallerTemplate/platformDetection vitest 20/20 + 7/7、三个 workflow YAML 解析通过。
# Conflicts: # .github/workflows/windows-server-2012-r2.yml
t8y2
left a comment
There was a problem hiding this comment.
Follow-up maintainer push: merged latest main (24642a6) — merge commit 292c73c. One modify/delete conflict: .github/workflows/windows-server-2012-r2.yml was deleted on main by #7940 (completed manual diagnostic entry, no other references) while this branch had edited it. Resolved by accepting the deletion — the branch's edits to that file (offline-setup renames inside the removed diagnostic workflow) are moot; all other files auto-merged. node --test scripts/release.test.mjs green after the merge; git diff --check clean. CI (incl. windows-win7-bundle, re-triggered by the release.yml path) will re-validate on this head.
|
Thanks for the contribution! Merged in 321674c, will be released in the next version. |
改动说明
aarch64统一命名为arm64。*-offline-setup.exe,不在文件名中暴露 WebView2 实现细节。webview2-109文件名片段。aarch64-*target 标识及运行时实现不变。验证
git diff --cached --check通过。actionlint .github/workflows/release.yml .github/workflows/windows-server-2012-r2.yml .github/workflows/publish-packages.yml未发现 YAML 或 GitHub Actions 表达式错误;仅报告主线已有的 ShellCheck/custom runner 提示。