-
Notifications
You must be signed in to change notification settings - Fork 5
Sitemap generator #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bmordan
wants to merge
6
commits into
master
Choose a base branch
from
sitemap-generator
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
43720a4
start of simple sitemap generator
bmordan dd46cbe
places sitemap.txt in dist - filters 'home' dir
bmordan 9e105d7
remove edit from another PR
bmordan f09fc70
Merge branch 'master' into sitemap-generator
bmordan a0f287b
handles errors better, uses async.filter
bmordan 3356d73
async the stat in filter...
bmordan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| var fs = require('fs') | ||
| var path = require('path') | ||
| var async = require('async') | ||
| var packageJson = require('../package.json') | ||
| var inputDir = path.normalize(path.join(__dirname, '..', 'pages')) | ||
| var outputDir = path.normalize(path.join(__dirname, '..', 'dist')) | ||
|
|
||
| if (!packageJson.config.deploy.prod) throw new Error('Can\'t find packageJson.config.deploy.prod') | ||
|
|
||
| async.waterfall([ | ||
| function read (done) { | ||
| fs.readdir(inputDir, done) | ||
| }, | ||
| function filter (contents, done) { | ||
| async.filter(contents, function (item, callback) { | ||
| fs.stat(path.join(inputDir, item), function (err, stat) { | ||
| if (err) return callback(err) | ||
| callback(null, stat.isDirectory && item !== 'home') | ||
| }) | ||
| }, done) | ||
| }, | ||
| function createUrls (pages, done) { | ||
| var routes = pages.map(function (page) { return 'https://' + packageJson.config.deploy.prod + '/' + page }) | ||
| var sitemap = routes.join('\n') | ||
| var writePath = path.join(outputDir, 'sitemap.txt') | ||
| fs.writeFile(writePath, sitemap, done) | ||
| } | ||
| ], function (err) { | ||
| if (err) throw err | ||
| console.log('Created dist/sitemap.txt') | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be an idea to check this value exists before starting the waterfall and throw an error if not.
I also think our build config should all be in a "tune" property in the
package.json. Currently, we're scattered inconfig.deploy.prod,subPagesetc. for another PR perhaps