Accept XLUnicodeRichExtendedString without reserved tag#571
Merged
jmcnamara merged 4 commits intotafia:masterfrom Oct 24, 2025
Merged
Accept XLUnicodeRichExtendedString without reserved tag#571jmcnamara merged 4 commits intotafia:masterfrom
jmcnamara merged 4 commits intotafia:masterfrom
Conversation
jmcnamara
reviewed
Oct 24, 2025
Collaborator
There was a problem hiding this comment.
I think the change to continue_record() is good.
However, I don't think the commit message does it justice. "refactor: remove distinction between None and vec.is_empty()" doesn't say where the distinction is being removed. For something like this I would add a commit message like:
xls: refactor CONTINUE record handling
Refactored Record::continue_record() to remove the distinction
between None and vec.is_empty().
Collaborator
|
Overall the PR is good and I am happy to merge. Let me know if you wish to make any further changes. |
Contributor
Author
|
GTM |
Collaborator
|
Merged. Thanks. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analogous to #525 where the same was done for
XLUnicodeString, no file available for a test case.