Skip to content

xlsx: fix ignoring rich text <r> after initial plain <t>#637

Open
aquasync wants to merge 1 commit intotafia:masterfrom
aquasync:xlsx-richtext-after-plain
Open

xlsx: fix ignoring rich text <r> after initial plain <t>#637
aquasync wants to merge 1 commit intotafia:masterfrom
aquasync:xlsx-richtext-after-plain

Conversation

@aquasync
Copy link
Copy Markdown
Contributor

Currently read_string_with_bufs just ignores all subsequent events until closing tag if hitting a plain text node first. This causes it to ignore subsequent text in examples like this:

  <si>
    <t>tval</t>
    <r>
      <t>rval1</t>
    </r>
    <r>
      <t>rval2</t>
    </r>
  </si>

I guess this was for speed reasons? I think in the typical case the next event would be the closing tag anyway, so shouldn't be much different, and I don't think this introduces any additional copies. It does make rich_buffer a bit of a misnomer though, so maybe should be changed (though text_buf means something different in this function).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant