xlsx: handle minimal package structure#639
Open
aquasync wants to merge 2 commits intotafia:masterfrom
Open
Conversation
This is more robust and works with non-standard package layouts.
Not guaranteed to be xl/workbook.xml. Affects paths to many other xml components as they are relative to the workbook. Closes tafia#638
aquasync
force-pushed
the
xlsx-minimal-package
branch
from
01fdf1b to
ff3413e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code currently assumes the workbook xml (and related files) live in
xl/, however this needn't be the case. It further assumes the directory names can be relied upon to infer sheet types.The first is replaced with reading the document path from
_rels/.rels, and the latter from the types in the_rels/workbook.xml.rels.The code for the rels xml parsing seems a bit clunky; maybe cleaner way to do it with quick_xml, I was just following the approach used elsewhere.
I also considered just ignoring and trying extra known paths (eg "xl/workbook.xml", then "workbook.xml"), however it won't work with something like: arbitrarypath.xlsx.