xls: fix unsupported formula function panic#646
Open
mogery wants to merge 1 commit intotafia:masterfrom
Open
Conversation
mogery
force-pushed
the
fix/issue-646-xls-formula-panic
branch
from
3d5420d to
26301e7
Compare
Handle unsupported XLS function ids as formula parse errors instead of indexing past the function table, and cover issue 646 with a valid minimal XLS fixture. Made-with: Cursor
mogery
force-pushed
the
fix/issue-646-xls-formula-panic
branch
from
26301e7 to
4675775
Compare
Author
|
couple of force pushes to fix excel complaining about the fixture file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle unsupported XLS function ids as formula parse errors instead of indexing past the function table, and cover issue with a valid minimal XLS fixture.
Example real file that causes a panic: https://www.wmfs.net/wp-content/uploads/2022/03/Waste-Contracts.xls
Patch written with GPT-5.5