Rename multiple activities from one app separately#535
Open
gustav-langer wants to merge 2 commits intotanujnotes:masterfrom
Open
Rename multiple activities from one app separately#535gustav-langer wants to merge 2 commits intotanujnotes:masterfrom
gustav-langer wants to merge 2 commits intotanujnotes:masterfrom
Conversation
…ackage name. Apps with multiple launching activities can now be separately renamed.
Author
|
Actually, I didn't notice that resetting was already supported by deleting the rename text. This is now slightly broken as it resets to the application and not activity name, but should be fixable (but I currently don't know how). |
…re any renames. This field is used as the hint for the rename field, allowing renames of applications with multiple launching activities to be reset correctly.
gustav-langer
commented
Oct 31, 2024
| } | ||
| etAppRename.addTextChangedListener(object : TextWatcher { | ||
| override fun afterTextChanged(s: Editable?) { | ||
| etAppRename.hint = getAppName(etAppRename.context, appModel.appPackage) |
Author
There was a problem hiding this comment.
I am not sure about this piece of code. It seems to reload the app name every time something is typed. For what is this needed?
The updated code currently does not do this, and always uses the originalLabel set in Utils/getAppsList, which might need to be changed to restore the original behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request partly implements #415 by storing rename labels by component name instead of package name, which allows different activities to be renamed separately.
There is still no option to reset renames, so it isn't completely done. (I will however try to implement that soon as well.)
Please also add the
hacktoberfest-acceptedlabel to this pull request as it was made for Hacktoberfest 2024. Thank you for your awesome launcher!