Editorial: tweak PropertyDefinitionEvaluation and ClassElementEvaluation#2470
Merged
Editorial: tweak PropertyDefinitionEvaluation and ClassElementEvaluation#2470
Conversation
michaelficarra
approved these changes
Jul 28, 2021
michaelficarra
added
the
ready to merge
ljharb
force-pushed
the
propertydefinitionevaluation
branch
from
b0fb7bc to
99b36f0
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
…nd ClassElementEvaluation (tc39#2470)
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the first commit: The
_enumerable_parameter forPropertyDefinitionEvaluationwas always true; the parameter of the same name forClassElementEvaluationwas always false. Prior to #1668 PropertyDefinitionEvaluation was used for both object literals and classes. When it was split, the parameter became redundant.The second commit just fixes an oversight of mine from fe6b5ef (part of #2271).