Skip to content

Polyfill: Replace unreachable retry with assertion in NudgeToCalendarUnit #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jessealama wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Polyfill: Replace unreachable retry with assertion in NudgeToCalendarUnit #3291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d75c4a
Polyfill: Replace unreachable retry with assertion in NudgeToCalendar…
jessealama Mar 5, 2026
cb1916b
Editorial: Replace unreachable retry with assertion in NudgeToCalenda…
jessealama Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 5 additions & 19 deletions polyfill/lib/ecmascript.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3308,25 +3308,11 @@ function NudgeToCalendarUnit(
didExpandCalendarUnit = true;
}
} else if (sign == -1) {
if (!(nudgeWindow.endEpochNs.leq(destEpochNs) && destEpochNs.leq(nudgeWindow.startEpochNs))) {
// Retry nudge window if it's out of bounds
nudgeWindow = ComputeNudgeWindow(
sign,
duration,
originEpochNs,
isoDateTime,
timeZone,
calendar,
increment,
unit,
true
);
assert(
nudgeWindow.endEpochNs.leq(destEpochNs) && destEpochNs.leq(nudgeWindow.startEpochNs),
`${unit} was 0 days long`
);
didExpandCalendarUnit = true;
}
/* c8 ignore next */
assert(
nudgeWindow.endEpochNs.leq(destEpochNs) && destEpochNs.leq(nudgeWindow.startEpochNs),
`sign===-1 nudge window should always contain destEpochNs for ${unit}`
);
}
({ r1, r2, startEpochNs, endEpochNs, startDuration, endDuration } = nudgeWindow);

Expand Down
6 changes: 2 additions & 4 deletions spec/duration.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1672,10 +1672,8 @@ <h1>
1. Assert: _nudgeWindow_.[[StartEpochNs]] ≤ _destEpochNs_ ≤ _nudgeWindow_.[[EndEpochNs]].
1. Set _didExpandCalendarUnit_ to *true*.
1. Else,
1. If _endEpochNs_ ≤ _destEpochNs_ ≤ _startEpochNs_ is *false*, then
1. Set _nudgeWindow_ to ? ComputeNudgeWindow(_sign_, _duration_, _originEpochNs_, _isoDateTime_, _timeZone_, _calendar_, _increment_, _unit_, *true*).
1. Assert: _nudgeWindow_.[[EndEpochNs]] ≤ _destEpochNs_ ≤ _nudgeWindow_.[[StartEpochNs]].
1. Set _didExpandCalendarUnit_ to *true*.
1. Assert: _endEpochNs_ ≤ _destEpochNs_ ≤ _startEpochNs_.
1. NOTE: For negative durations, end-of-month constraining can only reduce the day number, which moves the endpoint further from the origin, so the nudge window always contains _destEpochNs_ without an additional shift.
1. Let _r1_ be _nudgeWindow_.[[R1]].
1. Let _r2_ be _nudgeWindow_.[[R2]].
1. Set _startEpochNs_ to _nudgeWindow_.[[StartEpochNs]].
Expand Down
Loading