Conversation
When constructing a PlainMonthDay from a property bag, it's possible to give a year that is way out of range. The spec text says to bail out early in that case, to avoid performing expensive calculations to validate the month and day. Previously, the polyfill did not do this early bail-out step. See: #....
This is clearer because isTemporalObject doesn't include Temporal.Duration.
Got these from running through TypeScript compiler.
As per #3309 we change Temporal.Duration.prototype.round step 28.d ! to ?, so we can no longer omit the IsValidDuration check here in the polyfill. (This has no observable effect, since out-of-range durations cause a later step to throw anyway, but we may as well update things here.
ptomato
added
the
run snapshot tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3313 +/- ##
==========================================
+ Coverage 97.83% 98.39% +0.55%
==========================================
Files 22 22
Lines 10725 10763 +38
Branches 1856 1866 +10
==========================================
+ Hits 10493 10590 +97
+ Misses 215 161 -54
+ Partials 17 12 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update test262 to the latest commit and make the necessary changes in the reference code to pass all new tests.