Invalidation event type proposal

[jan888adams]

Summary by CodeRabbit

• Tests

  • Enhanced test coverage for cache invalidation event handling with explicit event type validation.

• Refactor

  • Improved code organization and test infrastructure with property name clarification.

• Style

  • Minor code formatting adjustments.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch invalidation-event-type-proposal

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[Copilot]

Pull request overview

Introduces an explicit EventType for element invalidation events and updates unit tests to validate the dispatched event type for update vs delete operations.

Changes:

• Update ElementInvalidationEvent::fromElement(...) usages in tests to pass the new EventType (Update/Delete).
• Add new unit tests asserting that InvalidateElementListener dispatches invalidation events with the correct type.
• Rename a test property in TraceableResponseTaggerTest (currently inconsistent with remaining usages).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
tests/Unit/Element/InvalidateElementListenerTest.php	Passes EventType to ElementInvalidationEvent::fromElement and adds assertions for dispatched event type.
tests/Unit/Cache/ResponseTagger/TraceableResponseTaggerTest.php	Renames the tagger property, but the rename is incomplete and breaks the test.
src/Element/EventType.php	Adjusts file header formatting while defining the EventType enum (Update/Delete).

Comments suppressed due to low confidence (1)

tests/Unit/Cache/ResponseTagger/TraceableResponseTaggerTest.php:26

• The property was renamed to $traceableResponseTagger, but the rest of the test still assigns to and uses $collectTagsResponseTagger. This will result in an undefined property / failing tests. Please update setUp() and all usages to consistently use the new property name (or keep the old name everywhere).

    private TraceableResponseTagger $traceableResponseTagger;

    /** @var ObjectProphecy<ResponseTagger> */
    private ObjectProphecy $innerTagger;

    protected function setUp(): void
    {
        $this->innerTagger = $this->prophesize(ResponseTagger::class);
        $this->collectTagsResponseTagger = new TraceableResponseTagger($this->innerTagger->reveal());
    }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/Unit/Cache/ResponseTagger/TraceableResponseTaggerTest.php`:
- Line 17: The typed property TraceableResponseTagger $traceableResponseTagger
is declared but the tests use the wrong runtime property name
$collectTagsResponseTagger; update all usages to match the declared property by
replacing every $collectTagsResponseTagger with $traceableResponseTagger in
setUp() and the tests tag_should_collect_tags,
tag_should_forward_tags_to_inner_tagger, and reset_should_reset_collected_tags
so the typed property is actually used and no runtime property access issues
occur.

---

ℹ️ Review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0b13633 and 9ed6752.

📒 Files selected for processing (3)

• src/Element/EventType.php
• tests/Unit/Cache/ResponseTagger/TraceableResponseTaggerTest.php
• tests/Unit/Element/InvalidateElementListenerTest.php