Open
Conversation
… new version is deployed
Author
|
Just noting that the current travis build is pretty irrelevant for this pull. Not sure how you all would want to proceed after merging so I'll just leave it as is. |
Collaborator
|
@Kiser360 awesome work man, really appreciate it. |
|
This PR is amazing! 😍 Can you please check why I just see a white page with title and menu? |
Author
|
When I made this pr that's how the Caligator app worked, just focus/tap/click the left side and you can begin typing the expressions you need calculated. Been a while since I've rebased so things might be out of date |
|
Ah, it is working now. 😀 |
Collaborator
|
@pavanjadhaw @SarathSantoshDamaraju What are our plans with this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'll start by saying this is a hefty merge request, I've tried to make reasonable commits so you can focus on the commits you like if not the whole pull. The result of this pull is live at Caligator
There are many benefits to presenting Caligator as a PWA (Progressive Web App), as opposed to an Electron desktop application. I won't define what a PWA is right now but here are some benefits:
Included in this merge, the UI has been refactored to use a web framework called Svelte. Meaning no more manual DOM manipulation, this should be a big win. Also, because this is fully converted to a web application, this merge has no dependencies on Electron. OS theme detection is done using CSS Media Queries, also some dead CSS styles and variables have been removed.
I've rebased on master and verified the application still works, however due to the extensiveness of the refactor I couldn't be sure all changes on origin made since last night (when I started the fork) are functional, although they should be if they were isolated to 'core' Caligator functionality in the conversion modules.
I love whats been done with this app and I'm always happy to see people exploring software built with new web technologies, be it a PWA or Electron. I hope you can find some useful bits from this merge and feel free to leave me some feedback. Also this is my first OSS pull request so.... hype! 🎉