Add events to theme components#671
Conversation
|
|
🦋 Changeset detectedLatest commit: 7f12740 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
justlilith
changed the title
|
Hi @justlilith, thanks for the PR. At the moment Svelte UX has not been ported to Svelte 5 syntax (runes, snippets, etc) but is in the process of as part of a larger effort to consolidate it with LayerStack. I'll be posting more details soon. |
|
@techniq Thanks; sounds good! In the interim, should I replace the host rune with the deprecated createEventDispatcher so this might be merged? Or just hold off on this PR until the Svelte 5 migration? |
|
If you would want to use |
| classes | ||
| )} | ||
| {...$$restProps} | ||
| {...props} |
There was a problem hiding this comment.
We need to switch back to Svelte 4 $$restProps syntax as well
| "dependencies": { | ||
| "@layerstack/tailwind": "2.0.0-next.22", | ||
| "@sveltejs/adapter-cloudflare": "^7.2.8" | ||
| } |
| 'svelte-ux': minor | ||
| --- | ||
|
|
||
| This release adds events to theme selection. |
There was a problem hiding this comment.
let's change this to Add theme selection events
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
…cher; remove errant packages -L6
|
Looks good! Could you run |
|
@techniq all set, I think 👍 |
|
Thanks again @justlilith! Released and available as 2.0.0-next.24. FYI: We're currently in the process of updating LayerStack to use the new docs system we built for LayerChart (and is becoming a new I'll post more updates as this works progresses. |
2 participants
I noticed that there wasn't a way to tell what theme a user has selected, so this PR adds a new event (carrying a detail of the selected theme) when setting the theme.