Open
Conversation
AthreyVinay
added
step | prepare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request consolidates package installation methods into a single 'install' call, removes redundant container rebuilds in the 'bootc' manager, and optimizes 'rpm-ostree' presence checks. Feedback requires passing 'options' to 'super().install()' in 'rpm-ostree' to ensure settings are respected and including the installable name in 'apk' error messages for better clarity.
AthreyVinay
force-pushed
the
avinay-simplify-install-methods
branch
from
7adab73 to
0f5df8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originated from a comment here: #4605 (comment). Good to align before artifacts call various install methods.
also, a slight functional change in
RpmOstree.sort_packages()which now batches the presence check.