Skip to content

Handle test framework dependencies in required packages #4802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
psss wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Handle test framework dependencies in required packages #4802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tmt/steps/prepare/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,9 +279,9 @@ def go(self, force: bool = False) -> None:
self._logger,
)

collected_essential_requires[
guest
].dependencies += test.test_framework.get_requirements(test, self._logger)
collected_requires[guest].dependencies += test.test_framework.get_requirements(
test, self._logger
)
Comment on lines +282 to +284
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Use tmt.base.core.assert_simple_dependencies to ensure that test framework requirements are simple dependencies, maintaining consistency with how test.require and test.recommend are handled in the same loop. This also provides a more descriptive error message if a non-simple dependency is encountered.

                collected_requires[guest].dependencies += tmt.base.core.assert_simple_dependencies(
                    test.test_framework.get_requirements(test, self._logger),
                    'After beakerlib processing, tests may have only simple requirements',
                    self._logger,
                )


for check in test.check:
collected_essential_requires[
Expand Down
Loading