Conversation
7f66223 to
ac92ce2
Compare
There was a problem hiding this comment.
Code Review
This pull request transitions the recipe system to use absolute paths for results and refactors the RecipeManager to handle fmf tree creation internally. It also adds custom serialization for ReportPortal report data to ensure correct formatting of log limits and patterns. A suggestion was made to remove a redundant tree check in tmt/base/core.py to support recipe loading in standalone environments where a tree might not yet exist.
|
I tried to verify the fix by doing a basic tmt run via container. Then I moved into a blank directory with no fmf tree and tried to run with the recipe file: (PR) Looks like it made the fake tree, but the tree does not have the supporting test files. Am I reproducing this correctly? |
There was a problem hiding this comment.
Not sure if this PR is supposed to fix this or not, but I did a tmt run with report --how reportportal --project <my_project> and it made the recipe.yaml file with the key/values in the to_spec()\to_minimal_spec() functions. Then I tried loading that same recipe file (in the fmf root directory), and I got an exception:
/plans/all
summary: Run all tests
plan failed.
The exception was caused by 1 earlier exceptions
Cause number 1:
cannot represent an object: {1: '<some-hash>'}
Where {1: '<some-hash>'} is the reportportal test-uuids value.
This PR addresses the following issues in the recipe feature:
to_spec/to_minimal_specmethods to the ReportPortal plugin.Blocking: https://gitlab.cee.redhat.com/fvagner/tmt-recipe-tool/-/merge_requests/1
Pull Request Checklist