-
Notifications
You must be signed in to change notification settings - Fork 99
fix(react-typescript): non event props where missing in ts declaration #2488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christopherGdynia
wants to merge
2
commits into
telekom:main
Choose a base branch
from
christopherGdynia:fix-react-types
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,142 @@ | ||
| /** | ||
| * Type-level test for Scale React wrapper components. | ||
| * This file is type-checked only (tsc --noEmit), never executed. | ||
| * It verifies that generated React wrappers expose Stencil @Prop() as React props. | ||
| */ | ||
|
|
||
| import { | ||
| ScaleAlert, | ||
| ScaleButton, | ||
| ScaleTag, | ||
| ScaleTextField, | ||
| ScaleSwitch, | ||
| ScaleCheckbox, | ||
| ScaleSlider, | ||
| ScaleProgressBar, | ||
| ScaleCollapsible, | ||
| ScaleDropdownSelect, | ||
| ScaleDropdownSelectItem, | ||
| ScaleRadioButton, | ||
| ScaleRadioButtonGroup, | ||
| ScaleDatePicker, | ||
| ScaleTextarea, | ||
| ScaleRatingStars, | ||
| ScaleTelekomHeader, | ||
| ScaleTelekomNavItem, | ||
| } from '../dist/index'; | ||
| import React from 'react'; | ||
|
|
||
| // Helper: assert that a JSX expression is valid (compile-time only) | ||
| function expectValidJSX(_jsx: React.ReactElement): void {} | ||
|
|
||
| // --- ScaleAlert --- | ||
| expectValidJSX(<ScaleAlert variant="informational" opened headline="Test" />); | ||
| expectValidJSX(<ScaleAlert icon="info" size="small" />); | ||
|
|
||
| // --- ScaleButton --- | ||
| expectValidJSX(<ScaleButton variant="secondary" size="small" disabled />); | ||
| expectValidJSX(<ScaleButton type="submit">Submit</ScaleButton>); | ||
|
|
||
| // --- ScaleTag --- | ||
| expectValidJSX( | ||
| <ScaleTag size="small" color="green"> | ||
| Active | ||
| </ScaleTag> | ||
| ); | ||
| expectValidJSX(<ScaleTag dismissable type="strong" />); | ||
|
|
||
| // --- ScaleTextField --- | ||
| expectValidJSX(<ScaleTextField label="Name" value="John" required />); | ||
| expectValidJSX( | ||
| <ScaleTextField label="Email" type="email" helperText="Enter email" /> | ||
| ); | ||
|
|
||
| // --- ScaleSwitch --- | ||
| expectValidJSX(<ScaleSwitch label="Dark Mode" checked />); | ||
|
|
||
| // --- ScaleCheckbox --- | ||
| expectValidJSX(<ScaleCheckbox label="Accept terms" checked />); | ||
| expectValidJSX(<ScaleCheckbox indeterminate disabled />); | ||
|
|
||
| // --- ScaleSlider --- | ||
| expectValidJSX( | ||
| <ScaleSlider | ||
| label="Volume" | ||
| min={0} | ||
| max={100} | ||
| value={50} | ||
| showValue | ||
| innerAriaValueText="50%" | ||
| /> | ||
| ); | ||
|
|
||
| // --- ScaleProgressBar --- | ||
| expectValidJSX( | ||
| <ScaleProgressBar percentage={75} percentageStart={0} showStatus /> | ||
| ); | ||
|
|
||
| // --- ScaleCollapsible --- | ||
| expectValidJSX( | ||
| <ScaleCollapsible expanded> | ||
| <div>Content</div> | ||
| </ScaleCollapsible> | ||
| ); | ||
|
|
||
| // --- ScaleDropdownSelect + Item --- | ||
| expectValidJSX( | ||
| <ScaleDropdownSelect label="Choose" value="a"> | ||
| <ScaleDropdownSelectItem value="a" selected> | ||
| Option A | ||
| </ScaleDropdownSelectItem> | ||
| <ScaleDropdownSelectItem value="b">Option B</ScaleDropdownSelectItem> | ||
| </ScaleDropdownSelect> | ||
| ); | ||
|
|
||
| // --- ScaleRadioButtonGroup + ScaleRadioButton --- | ||
| expectValidJSX( | ||
| <ScaleRadioButtonGroup label="Choice"> | ||
| <ScaleRadioButton label="Option 1" value="1" checked /> | ||
| <ScaleRadioButton label="Option 2" value="2" /> | ||
| </ScaleRadioButtonGroup> | ||
| ); | ||
|
|
||
| // --- ScaleDatePicker --- | ||
| expectValidJSX(<ScaleDatePicker label="Start date" value="2026-01-01" />); | ||
|
|
||
| // --- ScaleTextarea --- | ||
| expectValidJSX(<ScaleTextarea label="Message" rows={5} required />); | ||
|
|
||
| // --- ScaleRatingStars --- | ||
| expectValidJSX( | ||
| <ScaleRatingStars | ||
| size="large" | ||
| rating={4} | ||
| max={5} | ||
| label="Rating" | ||
| ariaLabelTranslation="$value out of $max" | ||
| disabled={false} | ||
| hideLabel={false} | ||
| readonly={false} | ||
| /> | ||
| ); | ||
|
|
||
| // --- ScaleTelekomHeader --- | ||
| expectValidJSX( | ||
| <ScaleTelekomHeader appName="My App" appNameLink="/"> | ||
| <div>Nav</div> | ||
| </ScaleTelekomHeader> | ||
| ); | ||
|
|
||
| // --- ScaleTelekomNavItem --- | ||
| expectValidJSX( | ||
| <ScaleTelekomNavItem active> | ||
| <a href="/">Home</a> | ||
| </ScaleTelekomNavItem> | ||
| ); | ||
|
|
||
| // --- Negative tests: unknown props should NOT compile --- | ||
| // @ts-expect-error — nonExistentProp is not a valid prop | ||
| expectValidJSX(<ScaleAlert nonExistentProp="x" />); | ||
|
|
||
| // @ts-expect-error — nonExistentProp is not a valid prop | ||
| expectValidJSX(<ScaleButton nonExistentProp={42} />); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file starts with a UTF-8 BOM (U+FEFF). Please remove it to avoid invisible-character diffs and potential issues with some tooling.