Conversation
Member
|
Don't merge until Andrew has fixed temporalio/sdk-rust#1197 |
THardy98
force-pushed
the
chore/bump-core
branch
from
3920919 to
739e730
Compare
sdk-core added protoc-gen-openapiv2 imports to cloud service protos.
This broke proto generation in two ways:
1. protoc couldn't resolve the import — none of the existing --proto_path
entries point to a directory where protoc-gen-openapiv2/ is a child.
Fix: add protos/ as --proto_path, but only for the cloud protos call
(via extra_proto_paths param). Adding it globally causes duplicate
definition errors since files under api_upstream/ become reachable
through both protos/api_upstream and protos/.
2. The generated service.rb requires the openapiv2 Ruby files, which
didn't exist. generate_service_files loads service.rb to reflect on
the service descriptor, so the missing require crashes the build.
Fix: generate openapiv2 protos into lib/protoc-gen-openapiv2/.
Mirrors sdk-dotnet#633.
THardy98
force-pushed
the
chore/bump-core
branch
from
739e730 to
25c4614
Compare
chris-olszewski
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
DWISOTT
Why?
Propagate envconfig fix in sdk-core to Python