Skip to content

chore(ci): install protoc when building gems#425

Merged
chris-olszewski merged 9 commits intomainfrom
olszewski/fix_gem_build
Apr 27, 2026
Merged

chore(ci): install protoc when building gems#425
chris-olszewski merged 9 commits intomainfrom
olszewski/fix_gem_build

Conversation

@chris-olszewski
Copy link
Copy Markdown
Member

@chris-olszewski chris-olszewski commented Apr 22, 2026

What was changed

Ensure correct protoc version is installed when we build gems for release. For source releases this is straightforward, for our cross-compiled gems we need to customize the docker image used to ensure it has protoc installed.

Why?

In my excitement for #414, I forgot that Gems only get build on main so I didn't catch that these jobs were failing.

Checklist

  1. Closes N/A

  2. How was this tested:

This PR initially also configured the Gem builds to happen on PRs as well as main: here is an example run of the gems building correctly.

  1. Any docs updates needed?
    N/A

@chris-olszewski chris-olszewski marked this pull request as ready for review April 24, 2026 14:52
@chris-olszewski chris-olszewski requested a review from a team as a code owner April 24, 2026 14:52
@chris-olszewski chris-olszewski force-pushed the olszewski/fix_gem_build branch from 4bb76ee to ba54b8c Compare April 24, 2026 19:27
Copy link
Copy Markdown

@cconstable cconstable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chris-olszewski chris-olszewski merged commit faf7724 into main Apr 27, 2026
7 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/fix_gem_build branch April 27, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants