Skip to content

add missing configuration in BuildService function #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sgao640 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add missing configuration in BuildService function #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions pkg/simplecontent/config/env.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,16 @@ import (
// - "file:///path/to/data" - Filesystem storage
// - "s3://bucket?region=us-east-1" - S3 storage
//
// URL Strategy:
//
// URL_STRATEGY - URL generation strategy (one of):
// - "content-based" - Generate URLs based on content ID (default)
// - "storage-delegated" - Delegate URL generation to storage backend (presigned URLs)
// - "cdn" - Use CDN URLs for downloads
// API_BASE_URL - Base URL for content-based strategy (default: "/api/v1")
// CDN_BASE_URL - Base URL for CDN strategy downloads
// UPLOAD_BASE_URL - Base URL for CDN strategy uploads
//
// That's it! Use programmatic config for advanced features.
func WithEnv(prefix string) Option {
return func(c *ServerConfig) error {
Expand All @@ -46,6 +56,11 @@ func WithEnv(prefix string) Option {
return err
}

// URL Strategy config
if err := applyURLStrategyEnv(prefix, c); err != nil {
return err
}

return nil
}
}
Expand Down Expand Up @@ -101,6 +116,37 @@ func applyStorageEnv(prefix string, c *ServerConfig) error {
return fmt.Errorf("unsupported STORAGE_URL format: %s (use 'memory://', 'file://...', or 's3://...')", storageURL)
}

// applyURLStrategyEnv applies URL strategy configuration from environment
func applyURLStrategyEnv(prefix string, c *ServerConfig) error {
// URL_STRATEGY - URL generation strategy
if strategy, ok := lookupEnv(prefix, "URL_STRATEGY"); ok && strategy != "" {
// Validate strategy
switch strategy {
case "content-based", "storage-delegated", "cdn":
c.URLStrategy = strategy
default:
return fmt.Errorf("invalid URL_STRATEGY: %s (use 'content-based', 'storage-delegated', or 'cdn')", strategy)
}
}

// API_BASE_URL - Base URL for content-based strategy
if apiBaseURL, ok := lookupEnv(prefix, "API_BASE_URL"); ok && apiBaseURL != "" {
c.APIBaseURL = apiBaseURL
}

// CDN_BASE_URL - Base URL for CDN strategy downloads
if cdnBaseURL, ok := lookupEnv(prefix, "CDN_BASE_URL"); ok && cdnBaseURL != "" {
c.CDNBaseURL = cdnBaseURL
}

// UPLOAD_BASE_URL - Base URL for CDN strategy uploads
if uploadBaseURL, ok := lookupEnv(prefix, "UPLOAD_BASE_URL"); ok && uploadBaseURL != "" {
c.UploadBaseURL = uploadBaseURL
}

return nil
}

// applyFilesystemStorage configures filesystem storage from URL
// Format: file:///path/to/data
func applyFilesystemStorage(url string, c *ServerConfig) error {
Expand Down
Loading